-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SwiftLint to codebase #86
Comments
I can help with that. Would you be up to add Github Action to prevent merging inconsistent code? Usually it better to have several places to enforce linting, as contributors can bypass it on their local machine. In my experience, Xcode project script + CI check works great. |
@Garfeild Project script + CI running on every PR would be ideal setup 👍🏻 |
I have tried to integrate SwiftLint as plugin. There are some pros and cons with such integration. Pros:
Cons
Personally, I think it gives us good start and we can ignore first problem and mitigate second. And I would still introduce CI check. |
The goal of this issue is to add
SwiftLint
to the codebase to make code more consistent.https://github.com/realm/SwiftLint
The text was updated successfully, but these errors were encountered: