Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best way to enrich with my own requirements? #2

Closed
RooieRakkert opened this issue Mar 1, 2019 · 2 comments
Closed

Best way to enrich with my own requirements? #2

RooieRakkert opened this issue Mar 1, 2019 · 2 comments

Comments

@RooieRakkert
Copy link

I'm in love with your level-based approach for these Dockers! Great job and thanks for sharing!
However, what would you recommend as the favorable approach to enrich them with my own requirements/dependencies?

For example, if I'd like to run Keras on my GPU, with some new dependencies which are not currently present in your base image..
Would you recommend to create a new Dockerfile, build FROM keras-10.0-cudnn7 as base image, add my dependencies here?

Or, should I change your base 10.0-cudnn7 Dockerfile and insert my own dependencies, then build everything from scratch?

@okwrtdsh
Copy link
Owner

okwrtdsh commented Mar 4, 2019

@RooieRakkert
Thanks for your comment!

I prefer to add at run time when I have few requirements.

On the other hand, when I have many (or large) requirements or I need build something to add them, I often create a new Docker Image. (In this case, the purpose of Docker Image often changes.)

When requirements are depended on keras, I select keras-XXX-cudnnX as base image.
When they are needed to build keras, I select tf-XXX-cudnnX or XXX-cudnnXas base image.

I'm sorry for my broken English...

@RooieRakkert
Copy link
Author

Cheers, thanks! I'll go for the second option, creating a new Docker image based on the latest image, updated with additional required dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants