Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report email: synchronize() & detecteyemovements() #27

Open
olafdimigen opened this issue Dec 7, 2022 · 2 comments
Open

Bug report email: synchronize() & detecteyemovements() #27

olafdimigen opened this issue Dec 7, 2022 · 2 comments

Comments

@olafdimigen
Copy link
Owner

Thanks to user Maria for this bug report!

I came across the following issues when using the eye-eeg plugin for eeglab.

In eye-eeg-0.99\synchronize.m

Line 247
Should be
new_ix = zeros(size(ET.event, 1),1);

Instead of
new_ix = zeros(length(ET.event),1);

Also in \eye-eeg-0.99\detecteyemovements.m

Line 240

find(ismember({EEG.event.type},'bad_ET'))

gives an error – at least with my eeglab data
“Error using cell/ismember (line 34)
Input A of class cell and input B of class char must be cell arrays of character vectors,
unless one is a character vector.”

@olafdimigen
Copy link
Owner Author

(Test dataset provided)

@olafdimigen
Copy link
Owner Author

Comments: Bug 1 should be fixed in latest code. Bug 2 almost certainly due to user having integers in EEG.event.type which is deprecated and causes ismember() to fail once converted to cell. Hotfix is to convert EEG.event.type to strings using num2str(). ToDo: catch this special case (and possibly convert EEG.event.type to string with user warning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant