Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full qualified names in headers #48

Closed
GoogleCodeExporter opened this issue Mar 12, 2015 · 3 comments
Closed

Use full qualified names in headers #48

GoogleCodeExporter opened this issue Mar 12, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

ctemlate 0.96 generates

#include <ctemplate/template_string.h>
static const StaticTemplateString kM_MenuItem =
STS_INIT_WITH_HASH(kM_MenuItem, "MenuItem", 12751148691163768839LLU);

It will be better if the is generated as

static const ctemplate::StaticTemplateString kM_MenuItem =
STS_INIT_WITH_HASH(kM_MenuItem, "MenuItem", 12751148691163768839LLU);

In that way i will be not forced to put "using namespace ctemplate;" before
include the generated file

Original issue reported on code.google.com by pepone.o...@gmail.com on 24 Nov 2009 at 8:00

@GoogleCodeExporter
Copy link
Author

This is a good point.  I'll actually make it
   static const ::ctemplate::StaticTemplateString kM_MenuItem = ...
(note the leading ::).  Would that work for you?

I'll make that part of the next release.

Original comment by csilv...@gmail.com on 24 Nov 2009 at 9:07

  • Changed state: Started
  • Added labels: Type-Defect, Priority-Medium

@GoogleCodeExporter
Copy link
Author

Yeah it would be perfect

Original comment by pepone.o...@gmail.com on 24 Nov 2009 at 10:36

@GoogleCodeExporter
Copy link
Author

This should be fixed in ctemplate 0.97, just released.

Original comment by csilv...@gmail.com on 20 Apr 2010 at 5:55

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant