Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to disable the button? #18

Open
jsndk opened this issue Oct 27, 2014 · 5 comments
Open

Not possible to disable the button? #18

jsndk opened this issue Oct 27, 2014 · 5 comments

Comments

@jsndk
Copy link

jsndk commented Oct 27, 2014

Nice button, :-)
But if i want to disable it, it does not respect the disable="disabled" attribute on the checkBox.
Do i need to do something different?

@olance
Copy link
Owner

olance commented Oct 27, 2014

ah, it's "funny" that you're the first one to even ask for this... it's indeed missing!
My feeling is that this code need to be overhauled anyway, so I do accept pull request but do not have much time to invest on the current code...
I'm still hoping to create a "switchButton2" script at some point!

@jsndk
Copy link
Author

jsndk commented Oct 27, 2014

hey,

He He, This happens to the best. :-)

You already have a merge request for the readonly feature, and i can use
this for the same purpose. (display the value to the user but they can't
change it.) so if you accept this merge then im good.

(merge is from kizz246 https://github.com/kizz246 wants to merge 1
commit into olance:master from kizz246:master )

2014-10-27 13:07 GMT+01:00 Olivier Lance notifications@github.com:

ah, it's "funny" that you're the first one to even ask for this... it's
indeed missing!
My feeling is that this code need to be overhauled anyway, so I do accept
pull request but do not have much time to invest on the current code...
I'm still hoping to create a "switchButton2" script at some point!


Reply to this email directly or view it on GitHub
#18 (comment)
.

@olance
Copy link
Owner

olance commented Oct 30, 2014

:)

Okay, I'll find time to review the PR and get everything merged! 👍

@jsndk
Copy link
Author

jsndk commented Oct 30, 2014

Perfekt 😊

Sendt fra min Windows Phone

-----Oprindelig meddelelse-----
Fra: "Olivier Lance" notifications@github.com
Sendt: ‎30-‎10-‎2014 06:58
Til: "olance/jQuery-switchButton" jQuery-switchButton@noreply.github.com
Cc: "jsndk" ajjmnielsen@gmail.com
Emne: Re: [jQuery-switchButton] Not possible to disable the button? (#18)

:)
Okay, I'll find time to review the PR and get everything merged!

Reply to this email directly or view it on GitHub.=

@mariiine
Copy link

mariiine commented Nov 8, 2015

Hi!
Nice tool indeed :)
Did you finally make the change to accept a "disabled" state?
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants