- Does the documentation build? Does
make html
return errors?
- Is there a proper regression test?
- Is the feature documented?
- If you are adding new Django views that make use of Fedora commons functionalities or Solr functionalities, please make sure you use either the
base.viewmixins.FedoraServiceRequiredMixin
or thebase.viewmixins.SolrServiceRequiredMixin
- Are the strings internationalized?
- Is the base language of strings French?
- Does the coding style conform to the guidelines? Are there any flake8 errors?
- Is the test suite passing?
- Does the commit message follow the project standards?
- Does the front-end generally follow these guidelines?
- Does the Sass respect the 7-1 architecture pattern?
- Do the classes adhere to a consistent naming convention using hyphens for Sass and camelCase for JavaScript? ** Do the code follow the project's javascript development guidelines ?