Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement delete_matched #70

Closed
julianrubisch opened this issue Nov 17, 2023 · 4 comments
Closed

Implement delete_matched #70

julianrubisch opened this issue Nov 17, 2023 · 4 comments

Comments

@julianrubisch
Copy link
Contributor

as per https://api.rubyonrails.org/classes/ActiveSupport/Cache/Store.html#method-i-delete_matched

@oldmoe
Copy link
Owner

oldmoe commented Dec 11, 2023

Delete matched would require having the regex SQLite extension installed, maybe we can detect it and run the matcher only if it exists otherwise return a proper error message. The other option is to try and bundle the extension with Litestack (tricky but probably doable)

@adrienpoly
Copy link
Contributor

adrienpoly commented Jan 9, 2024

FYI rails/rails#50443 (comment)

looks like delete_matched could be deprecated in 7.2 and removed in 8.0 so probably best to wait for this issue to resolve before moving forward on that

@skatkov
Copy link

skatkov commented Jan 9, 2024

Plenty of cache stores don't have this method. Is there really a need in that?

@julianrubisch
Copy link
Contributor Author

I agree that if it's deprecated there's no need implementing it. FWIW I always found it handy when developing locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants