-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It appears that the calculation for point inside is not correct when the button image dimensions do not match the button size dimensions #1
Comments
Thanks for this. I also received a couple of comments on my blog that my code does not work in all cases. I will try to put some time into this class in the next few weeks. |
I finally fixed this. |
u r genius man.awesome |
thanks~~ |
really good.. what a genius man. thanks |
handsome boy ,this is there Swift version |
@pppqppqpphejj No. See #11 for an explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It appears that the code does not account for image sizes that do not match the button size (probably only applies to development builds as production images should match the button size).
I added the following logic inside of "pointInside" to account for image sizes that do not match the button size (I did not test for Retina Display @2x images). You may be able to design something more elegant.
The text was updated successfully, but these errors were encountered: