Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Child Theme outputting duplicate CSS #124

Closed
tsmith0511 opened this issue Oct 7, 2014 · 5 comments
Closed

Child Theme outputting duplicate CSS #124

tsmith0511 opened this issue Oct 7, 2014 · 5 comments

Comments

@tsmith0511
Copy link

Hi there!

I LOVE this theme and have used it several times. This time I'm trying to implement the child theme. But for some reason my CSS is outputting multiple times/ is duplicated. I installed the parent theme first, then the child. I have the parent theme "FoundationPress" and its child "FoundationPress-child" in my theme folder and have the child theme activated. My app.scss file came with the following import settings:
@import "settings";
@import "../FoundationPress/scss/app";
@import "custom"; // Custom child theme styles
@import "foundation";

Including the selective components.

I haven't made any changes to any file yet. Any idea why my css is outputting duplicate times?

Your time and help is much appreciated.

Thanks.

@ghost
Copy link

ghost commented Oct 8, 2014

Hi Tessa, are you using the Child Template from https://github.com/thetrickster/FoundationPress-child ?
If you're using above and build the CSS with grunt you dont have have to include the CSS from parent theme.

Anyway, I have some duplicated CSS rules too (even with the parent theme alone).
The following appear multiple times in my generated CSS, and its not the only rule:

*, *:before, *:after {
-webkit-box-sizing: border-box;
-moz-box-sizing: border-box;
box-sizing: border-box;
}

I believe thats because because of a bug with SASS <> Foundation 5.4.3? There's a roll-back to Foundation 5.3.x now, but I haven't tried it yet. Not sure it's because of this issues? Let me know anything you've found out.

@ghost
Copy link

ghost commented Oct 8, 2014

See here: #114

@olefredrik
Copy link
Owner

Hi Tessa,

As @Dotmagic said, there was a bug with SASS and the latest version of Foundation. This bug resulted in some duplicated css. I rolled back to a previous version of Foundation in commit 1ec6395

I suggest you try updating to the latest version of FoundationPress to see if your problem persists. If you're not sure how to fetch the latest version of FoundationPress, see this #118

Thanks. :)

Ole Fredrik

@gakimball
Copy link

libsass is fixed in Foundation 5.4.6, which came out yesterday, so you guys should be good to upgrade.

@olefredrik
Copy link
Owner

Thanks @gakimball . Good job :) Fixed.

ece872e
23aba74

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants