Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Top Bar Navigation not showing in 796px width or below. #318

Closed
marvinsss2005 opened this issue May 1, 2015 · 2 comments
Closed

Top Bar Navigation not showing in 796px width or below. #318

marvinsss2005 opened this issue May 1, 2015 · 2 comments

Comments

@marvinsss2005
Copy link

Hi,

When the width reach 796px or below the top bar navigation is gone and covered by the homepage-hero background the same with your demo site http://foundationpress.olefredrik.com.

Thanks...

@Aetles
Copy link
Contributor

Aetles commented May 2, 2015

Yeah, it becomes hidden because .top-bar has a specific height and the ul with the navigation is pushed down when it doesn't fit. If you remove height from .top-bar or change it to auto then the top bar navigation is shown on a second line, just like it does on the Foundations Docs when the width is around 600 px.

(The Foundation front page on the other hand has the navigation menu set to mobile menu at a much wider width, so this never happens there.)

@olefredrik
Copy link
Owner

Hello. Ideally, we would have a dynamic breakpoint calculated, based on the width of the menu contents at any time. This would however be a complicated affair that would require a slight portion of javascript in order to work. There is a reason why this isn't already a part of the Foundation core.

Anyway, I've managed to come up with a solution that allows you to set a custom breakpoint value deciding when the topbar visibility should be switched with the mobile menu. Please see this pull request for details: #323 .

The FoundationPress demo site is now updated with the topbar breakpoint fix. (You may need to delete your cache to get the latest css).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants