Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

npm run package do not minify js #695

Closed
dantahoua opened this issue Jan 28, 2016 · 5 comments
Closed

npm run package do not minify js #695

dantahoua opened this issue Jan 28, 2016 · 5 comments

Comments

@dantahoua
Copy link
Contributor

Hello.
Don't you think it would be better if "npm run package" create a "production" package?
Actually when we create a package, the js is not minified.
If I do "npm run production" the js is minified but I don't have any package...

@colin-marshall
Copy link
Collaborator

I agree that it would be better the way you suggest. In the meantime, you can run:

gulp package --production

That should give you minified files in your package.

@dantahoua
Copy link
Contributor Author

Thanks Colin, but I already tried "npm run package --production" and the foundation.js is not minified... ;)
I tried different combination of command but cannot achieve the desired result. (I'm not that good with npm,gulp, but I learn fast!).
Anyway for now I just copy manualy the js generated by "production" in the package...

@colin-marshall
Copy link
Collaborator

The command you tried is different from the one I told you to use. Try the one I suggested.

@dantahoua
Copy link
Contributor Author

Oh yeah, sorry! I add to install gulp globally to be able to run the "gulp" command and yes it's working. Thanks.

@dantahoua
Copy link
Contributor Author

Thanks! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants