Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

bower components _global overriding scss/global/_setting #762

Closed
cucocreative opened this issue Mar 9, 2016 · 5 comments
Closed

bower components _global overriding scss/global/_setting #762

cucocreative opened this issue Mar 9, 2016 · 5 comments

Comments

@cucocreative
Copy link

I have just move from using 1.6 to 2.5.1 and use CodeKit to compile the the css on a Mac running 10.10.5.

I don't know what I am doing wrong but compared to 1.6, the bower components seems to override the the my custom settings. For example if I change the colour for $secondary-color in the file assets/scss/global/settings once it is compiled the colour is equal to what was defined in one of the files within assets/components/foundation-files/scss/...

@dantahoua
Copy link
Contributor

Interesting, I just discovered the same problem but I do not use codekit, just regular npm...
In assets/scss/global/_setting.scss I changed $primary-color: red; BUT the color color shown in the website still is the default foundation one...

@dantahoua
Copy link
Contributor

Update: If I change the order in foundation.scss, putting the '@import "global/settings";' after the '@import '../components/foundation-sites/scss/foundation';'
it works, wich in a way make sense I think. What I don't understand is why it has been working before!!! I made two website with new FoundationPress and it was working!

@olefredrik
Copy link
Owner

Hi guys.

This issue was fixed earlier today. Here is the pull request #761 .

You can either pull the latest master branch or simply check out the updated _settings.scss where the new foundation-palette mixin has been introduced.

Cheers,
Ole Fredrik

@dantahoua
Copy link
Contributor

And you know what Ole, I saw it in my mail earlier!!! Holy s@$t !! Ah ah, I must pay more attention to the latest pull! :)

@olefredrik
Copy link
Owner

The reason it was working before, is that the Foundation team introduced the new foundation palette in the 6.2 update. You can find more details here if interested.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants