Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Copy task: Motion UI and What Input #922

Closed
emaia opened this issue Dec 4, 2016 · 2 comments
Closed

Copy task: Motion UI and What Input #922

emaia opened this issue Dec 4, 2016 · 2 comments

Comments

@emaia
Copy link
Contributor

emaia commented Dec 4, 2016

Hi guys!

I have a question about the copy task in the gulpfile.js (v2.8.0).
In the file we have this:

// Copy task
gulp.task('copy', function() {

  // Motion UI
  var motionUi = gulp.src('assets/components/motion-ui/**/*.*')
    .pipe($.flatten())
    .pipe(gulp.dest('assets/javascript/vendor/motion-ui'));

  // What Input
  var whatInput = gulp.src('assets/components/what-input/**/*.*')
      .pipe($.flatten())
      .pipe(gulp.dest('assets/javascript/vendor/what-input'));

With this all the Motion UI and What Input files are placed in the javascript/vendor folder (including scss, css, md, json...) but the js files of both components are already included in javascript/foundation.js by Uglify task.

Is there any purpose for this in the copy job?
Thanks

@populationtwo
Copy link
Contributor

populationtwo commented Dec 15, 2016

I was wondering the same thing.

I second that. I think that task is unnecessary since the theme doesn't enqueue the script from assets/javascript/vendor. I searched the packaged file and couldn't find any instances of assets/javascript/vendor being used in the theme.

@olefredrik
Copy link
Owner

Technical debt. Thanks to @emaia for pointing it out. And thanks to @populationtwo for the pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants