Skip to content
This repository has been archived by the owner on Sep 16, 2019. It is now read-only.

Update Travis CI Build Checks #959

Closed
EricRihlmann opened this issue Mar 16, 2017 · 2 comments
Closed

Update Travis CI Build Checks #959

EricRihlmann opened this issue Mar 16, 2017 · 2 comments

Comments

@EricRihlmann
Copy link
Contributor

EricRihlmann commented Mar 16, 2017

Now with WP recommending PHP 7 or greater as the minimum requirements, is it really necessary to run a build job all the way back to PHP 5.2 and WP 4.1?

My Recommendation

  • Add PHP 7.1 (if initial build fails, switch to allowed failure until resolved)
  • Add PHP 7.0
  • Change PHP 5.6 from allowing to fail to required to pass
  • Remove anything older than PHP 5.6 (those versions are not even supported by PHP anymore)

Any thoughts?

@olefredrik
Copy link
Owner

Totally agree. Fixed #960

@EricRihlmann
Copy link
Contributor Author

Cool. Although, it looks like PHP 5.6 was removed and PHP 7.1 was added twice — once as being required and again as allowed to fail. Since PHP 7.1 is passing, we should do away with the allowed to fail test. How about getting PHP 5.6 back in there? (still supported by PHP and probably the most popular version) Also, instead of checking against WP versions 4.1, 4.2, how about just checking against the current version (already doing that) and the previous two versions — 4.5 and 4.6?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants