Skip to content
This repository has been archived by the owner on Mar 10, 2021. It is now read-only.

Refactor #1

Merged
merged 13 commits into from
Dec 8, 2018
Merged

Refactor #1

merged 13 commits into from
Dec 8, 2018

Conversation

obalunenko
Copy link
Owner

No description provided.

Oleg Balunenko added 7 commits December 8, 2018 19:45
- move model to separate package
- refactor Start function
- refactor tests
- add Repository interface
- implement db/mongo package that satisfy Repsotpry interface
now all databases implementations are in db package
@obalunenko obalunenko self-assigned this Dec 8, 2018
Oleg Balunenko added 2 commits December 8, 2018 19:59
@coveralls
Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 42

  • 28 of 159 (17.61%) changed or added relevant lines in 5 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-4.03%) to 44.348%

Changes Missing Coverage Covered Lines Changed/Added Lines %
config/config.go 26 29 89.66%
db/interface.go 0 6 0.0%
converter/converter.go 2 13 15.38%
main.go 0 50 0.0%
db/mongo/db.go 0 61 0.0%
Files with Coverage Reduction New Missed Lines %
converter/converter.go 1 63.51%
main.go 3 0.0%
Totals Coverage Status
Change from base Build 33: -4.03%
Covered Lines: 153
Relevant Lines: 345

💛 - Coveralls

Oleg Balunenko added 4 commits December 8, 2018 20:03
config: raname variables
config: fix test
converter: refactor test to use testify
db/mongo: refacto to use new variables names
Copy link

@sonarcloud sonarcloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 1
Code Smell Code Smells: 0

See all issues in SonarCloud

@obalunenko obalunenko merged commit bf2dd3c into master Dec 8, 2018
@obalunenko obalunenko deleted the reefactor branch December 9, 2018 01:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants