Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What versions of Node are supported? #11

Closed
alebelcor opened this issue Apr 8, 2016 · 4 comments
Closed

What versions of Node are supported? #11

alebelcor opened this issue Apr 8, 2016 · 4 comments
Labels

Comments

@alebelcor
Copy link

Looking at the code it would seem that it's Node v4+ but I'm not 100% sure. It's also missing in the package.json file.

@olegskl
Copy link
Owner

olegskl commented Apr 8, 2016

The code is written in ES6 with import statements that Node does not support yet. When you install a published package from npm, you get a babelified version which works on Node 0.12+. Travis builds are run on Node 0.12, 4, and 5. See .travis.yml.

@alebelcor
Copy link
Author

Huh, I'm on 0.12.13 and the package is throwing an error for me.

The problem seems to be Object.assign is not being transpiled into anything ES5.

Doing a quick check in the Node REPL it indicates that Object.assign is undefined (on 0.12.13), so maybe that's it.

It's weird that the build is not failing because of it though.

@olegskl olegskl added the bug label Apr 8, 2016
@olegskl
Copy link
Owner

olegskl commented Apr 8, 2016

Thanks for reporting this. Will be fixed soon.

@olegskl
Copy link
Owner

olegskl commented Apr 14, 2016

The reason why it didn't fail during Travis builds is because of babel-tape-runner which polyfills everything... so missing features like Object.assign are available while running tests. Bummer.

I'm closing this issue, but feel free to reopen it if the fix doesn't work for you. Thanks again for reporting the issue, much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants