Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-check whether images with "\"" symbol are downloaded correctly #6

Closed
OlehOnyshchak opened this issue May 3, 2020 · 1 comment
Closed

Double-check whether images with "\"" symbol are downloaded correctly #6

OlehOnyshchak opened this issue May 3, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@OlehOnyshchak
Copy link
Owner

In code we have img_name = img.title(as_filename=True, with_ns=False).replace("\"", "") and also as_filename paramer now removes it https://phabricator.wikimedia.org/T236614

But on the other hand, we have images on Commons like this https://commons.wikimedia.org/wiki/File:Leonard_%22Butch%22_Levy_in_his_Navy_uniform.jpg
@OlehOnyshchak OlehOnyshchak added the bug Something isn't working label May 3, 2020
@OlehOnyshchak
Copy link
Owner Author

Fixed 0fa7cd5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@OlehOnyshchak