Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to add extra cmd tags into setup #49

Closed
ysomad opened this issue Nov 22, 2023 · 3 comments
Closed

Add possibility to add extra cmd tags into setup #49

ysomad opened this issue Nov 22, 2023 · 3 comments

Comments

@ysomad
Copy link
Contributor

ysomad commented Nov 22, 2023

Hi!

I'm looking forward to use gotests with extra cmd options like -named and -template testify. Checked source code of gopher and find out that cmd args are hard coded and there is only -all flag for gotests.

It would be great to have possibility to specify extra args in setup:

require("gopher").setup {
  commands = {
    go  = {
      cmd = "go",
      args = {},
    },
    gotests = {
      cmd = "~/go/bin/gotests",
      args = {"all", "-named", "-template testify"}, 
    }
  },
}
@ysomad
Copy link
Contributor Author

ysomad commented Nov 22, 2023

I can try to implement it myself and make a PR, but the question is: @olexsmir what do you think about this feature?

@ysomad ysomad changed the title Add cmd args to lib calls Add possibility to add extra cmd tags into setup Nov 22, 2023
@olexsmir
Copy link
Owner

I have implemented something like that on develop branch see here

if you want to add support of more args to tools, I'd appreciate the PR

@ysomad
Copy link
Contributor Author

ysomad commented Nov 23, 2023

I have implemented something like that on develop branch see here

if you want to add support of more args to tools, I'd appreciate the PR

Opened PR with support of named tests - #50

@ysomad ysomad closed this as completed Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants