Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in RangeBar.onTouchEvent #15

Closed
ultraon opened this issue Nov 3, 2015 · 2 comments
Closed

Bug in RangeBar.onTouchEvent #15

ultraon opened this issue Nov 3, 2015 · 2 comments

Comments

@ultraon
Copy link

ultraon commented Nov 3, 2015

Hello, please fix bug in RangeBar.onTouchEvent, line #433.
Current version:

case MotionEvent.ACTION_UP:
            case MotionEvent.ACTION_CANCEL:
                this.getParent().requestDisallowInterceptTouchEvent(false);
                onActionUp(event.getX(), event.getY());
                return true;

Replace with:

            case MotionEvent.ACTION_UP:
                this.getParent().requestDisallowInterceptTouchEvent(false);
                onActionUp(event.getX(), event.getY());
                return true;
            case MotionEvent.ACTION_CANCEL:
                this.getParent().requestDisallowInterceptTouchEvent(false);
                return false;

These changes fix scrolling issue (unprompted rangebar changes) when RangebBar is in scrollable view.

@oli107
Copy link
Owner

oli107 commented Nov 3, 2015

Thanks. Do you want to do a PR?

@ultraon
Copy link
Author

ultraon commented Nov 3, 2015

Done, #16

@oli107 oli107 closed this as completed Nov 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants