Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeBar Mode => thumbs hiding when u setRangePingByValue , setByIndex, setTick = w/e its always hiding thumbs :D #60

Open
KarolMB opened this issue Mar 8, 2016 · 0 comments

Comments

@KarolMB
Copy link

KarolMB commented Mar 8, 2016

Problem is there

if (pinRadiusDP == -1) {
            mPinRadiusPx = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP,
                    DEFAULT_THUMB_RADIUS_DP,
                    mRes.getDisplayMetrics());
        } else {
            mPinRadiusPx = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP,
            ->>     pinRadiusDP,
                    mRes.getDisplayMetrics());
        }

pinRadiusDP == 0..0
soo its not going to the first condition.. and setting pinRadius to 0.0 DP so pins are invisible.

FAST SOLUTION:
change the dp value

  if (pinRadiusDP == -1) {
            mPinRadiusPx = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP,
                    DEFAULT_THUMB_RADIUS_DP,
                    mRes.getDisplayMetrics());
        } else {
            mPinRadiusPx = (int) TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP,
                -->>    DEFAULT_THUMB_RADIUS_DP,
                    mRes.getDisplayMetrics());
        }

but if You will update this library to new version change the condition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant