Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source file, line and column when evaluating the buffer or form #18

Closed
1 of 2 tasks
Olical opened this issue Apr 3, 2019 · 2 comments
Closed
1 of 2 tasks
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Olical
Copy link
Owner

Olical commented Apr 3, 2019

When you evaluate a form or the entire buffer you lose all location data for that symbol. If you load the file from disk (,rF) it'll have that information. I want to find a way to keep that location definition code during ,re, ,rE, and ,rf.

  • Clojure
  • ClojureScript
@Olical Olical added the enhancement New feature or request label Apr 3, 2019
@Olical Olical added this to the v1.0.0 milestone Apr 3, 2019
@Olical Olical self-assigned this Apr 3, 2019
Olical added a commit that referenced this issue Apr 18, 2019
@Olical
Copy link
Owner Author

Olical commented Apr 18, 2019

Found a way to set the file, line and column for evals. Just need to pass through the correct column and line for the kind of eval we're performing. Should mean that ALL evals of forms get given the correct line and column so go to def will work everywhere all the time.

Will still have to figure something out for ClojureScript though, hopefully there's some similar vars I can bind.

@Olical
Copy link
Owner Author

Olical commented May 4, 2019

Closing this without ClojureScript support for now. Really not sure how to go about it, maybe I'll come back to it in the future if I see value in it.

@Olical Olical closed this as completed May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant