Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucg_dev_ic contains wrong cmd/data sequence command #50

Open
5 of 10 tasks
olikraus opened this issue Jun 22, 2015 · 0 comments
Open
5 of 10 tasks

ucg_dev_ic contains wrong cmd/data sequence command #50

olikraus opened this issue Jun 22, 2015 · 0 comments
Labels
Milestone

Comments

@olikraus
Copy link
Owner

The wong code is this:
const ucg_pgm_uint8_t ucg_ssd1331_set_pos_dir0_seq[] =
{
UCG_CS(0), /* enable chip /
UCG_C10(0x015), UCG_VARX(0,0x0ff, 0), UCG_D1(0x07f), /
set x position /
UCG_C10(0x075), UCG_VARY(0,0x0ff, 0), UCG_VARY(0,0x0ff, 0), /
set y position /
UCG_DATA(), /
change to data mode */
UCG_END()
};

Correct code should be:
const ucg_pgm_uint8_t ucg_ssd1331_set_pos_dir0_seq[] =
{
UCG_CS(0), /* enable chip /
UCG_C10(0x015), UCG_VARX(0,0x0ff, 0), UCG_A1(0x07f), /
set x position /
UCG_C10(0x075), UCG_VARY(0,0x0ff, 0), UCG_VARY(0,0x0ff, 0), /
set y position /
UCG_DATA(), /
change to data mode */
UCG_END()
};

  • ucg_dev_ic_ili9163.c
  • ucg_dev_ic_ili9325_spi.c
  • ucg_dev_ic_ld50t6160.c
  • ucg_dev_ic_ssd1289.c
  • ucg_dev_ic_ssd1351.c
  • ucg_dev_ic_ili9325.c
  • ucg_dev_ic_ili9341.c
  • ucg_dev_ic_pcf8833.c
  • ucg_dev_ic_ssd1331.c --> fixed & tested
  • ucg_dev_ic_st7735.c

Some speed optimization might be possible: CD line is set too often here

@olikraus olikraus added the bug label Jun 22, 2015
@olikraus olikraus added this to the 1.03 milestone Jun 22, 2015
@olikraus olikraus modified the milestones: 1.4, 1.03 Jul 26, 2015
@olikraus olikraus modified the milestones: 1.5, 1.4 Jan 7, 2017
@olikraus olikraus modified the milestones: 1.5, 1.6 Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant