Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vote] Keep support for C++ Network Library #11

Closed
oliora opened this issue Dec 14, 2017 · 7 comments
Closed

[Vote] Keep support for C++ Network Library #11

oliora opened this issue Dec 14, 2017 · 7 comments
Labels

Comments

@oliora
Copy link
Owner

oliora commented Dec 14, 2017

Currently, ppconsul can be built with one of two two network libraries: libCURL or C++ Network Library. I'm thinking about dropping support for the latter one to simplify adding of TLS support (#12).

Before getting rid of C++ Network Library support I'd like to know how harmful it will be for ppconsul users. Thus I'm asking for feedback on this.

If you use ppconsul with C++ Network Library and have a reason to avoid switching to CURL then please vote for this ticket. I will appreciate if you also add a comment why do you need/want to use a C++ Network Library instead of CURL.

@oliora oliora added the voting label Dec 14, 2017
@oliora oliora changed the title Keep support for C++ Network Library [Vote] Keep support for C++ Network Library Dec 14, 2017
@jgornowich
Copy link
Contributor

I have just recently started using this library and libcurl has been sufficient.

@d36u9
Copy link

d36u9 commented Jan 19, 2018

Maybe off the topic. I would recommend beast (https://github.com/boostorg/beast) to replace both of them, it's header-only http lib built on boost.asio. it's fast and easy to use.

@oliora
Copy link
Owner Author

oliora commented Jan 20, 2018

@d36u9 thank you for recommendatio. I’ll take a look on it.

Its boost dependency makes it less interesting for me because I’d like to remove dependency on Boost at some point. C++17 + some modern TMP library can replace Boost in Ppconsul already.

@fquinner
Copy link

+1 to no boost, libcurl works for me.

1 similar comment
@06wagon
Copy link

06wagon commented Dec 15, 2018

+1 to no boost, libcurl works for me.

@to3a
Copy link

to3a commented Jul 17, 2019

@d36u91 Actually this is not bad idea, since boost is already part of project. Json11 and libb64 libraries also can be replaced with boost counterparts.

@oliora
Copy link
Owner Author

oliora commented May 12, 2020

C++ Network Library is finally removed. Now user can implement its own HTTP client implementation if default one based on libcurl does not work for them.

@oliora oliora closed this as completed May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants