Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change return annotation to Fluent? #3

Closed
axesilo opened this issue Dec 15, 2018 · 3 comments
Closed

Change return annotation to Fluent? #3

axesilo opened this issue Dec 15, 2018 · 3 comments

Comments

@axesilo
Copy link

axesilo commented Dec 15, 2018

screen shot 2018-12-15 at 9 38 10 am

This code runs fine, but pylint thinks I am working with an arbitrary generator, not a Fluent. Is there a return annotation somewhere that can be changed to Fluent?

P.S. This is a nice project.
@olirice
Copy link
Owner

olirice commented Dec 15, 2018

@axesilo I took this issue over to the pylint folks last month:
pylint-dev/pylint#2578

The type annotations are correct in flupy (mypy passes) but pylint can't detect type changes in decorators.

I'll refactor the type casting this week and confirm that it makes pylint happy

Thanks for reporting!

@axesilo
Copy link
Author

axesilo commented Dec 15, 2018

Great catch with pylint!

@olirice
Copy link
Owner

olirice commented Dec 20, 2018

Fixed in 1.0.4 release (live on pypi)
46a9734
Please let me know if you see pylint complain about anything else

@olirice olirice closed this as completed Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olirice @axesilo