We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit Hash 70690c5
Platform Arch Linux
Summary I've found that when ripple deleting a few clips (possibly involving cross fades or text nodes), olive crashes.
Steps to Reproduce
Here's one scenario that crashes:
Additional Information
I loaded up Olive in a debugger and it turns out the track variable is null on line 390:
olive/app/timeline/timelineundoripple.cpp
Line 390 in 70690c5
Adding something like this fixes the crashes:
Track *track = region.first; if(!track) { qWarning() << "Track is null!"; continue; }
If it's not supposed to be null, then we got other problems but it's a good idea to check for null here in any case.
The text was updated successfully, but these errors were encountered:
I get this same issue. It's definitely related to cross fades.
Sorry, something went wrong.
If you can confirm it's realated to transitions see #1842
Successfully merging a pull request may close this issue.
Commit Hash
70690c5
Platform
Arch Linux
Summary
I've found that when ripple deleting a few clips (possibly involving cross fades or text nodes), olive crashes.
Steps to Reproduce
Here's one scenario that crashes:
![2023-05-31_20-21](https://private-user-images.githubusercontent.com/425930/242459345-f170bb96-f632-4034-8500-e20c372bb11a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQxNjk4MDEsIm5iZiI6MTcyNDE2OTUwMSwicGF0aCI6Ii80MjU5MzAvMjQyNDU5MzQ1LWYxNzBiYjk2LWY2MzItNDAzNC04NTAwLWUyMGMzNzJiYjExYS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODIwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyMFQxNTU4MjFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02YmNjNjJiNDlmOGY4MjRmYzMyMDA2MmExNGY1OTRmNGYwMDk2OTQ1MmM2MzcwMjFjMjljMmYyM2FiNDk0NGY0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.VLWp55YFoh445utCPtdjFJ_gcB0E_NxhtJtiAnIe328)
Crash Report
Additional Information
I loaded up Olive in a debugger and it turns out the track variable is null on line 390:
olive/app/timeline/timelineundoripple.cpp
Line 390 in 70690c5
Adding something like this fixes the crashes:
If it's not supposed to be null, then we got other problems but it's a good idea to check for null here in any case.
The text was updated successfully, but these errors were encountered: