Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #79 and #85 #97

Merged

Conversation

uggel
Copy link
Contributor

@uggel uggel commented Aug 26, 2020

Package configuration fixed

PR Details

Description

Package configuration is wrong. Currently one needs to have the bin-folder of the venv in the PATH. That is not feasible since you often have one venv per project.

Related Issue

Issue #79 and #85

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the
    CONTRIBUTING
    document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@oliver-zehentleitner
Copy link
Member

Hi uggel!

Thank you for fixing this issue!

Does the init file only works without the shebang and the other comments from https://github.com/oliver-zehentleitner/unicorn-binance-websocket-api/blob/master/unicorn_binance_websocket_api.py ?

best regards,
Oliver

@uggel
Copy link
Contributor Author

uggel commented Aug 26, 2020

Hi Oliver!
Yes that is correct. Initially init.py isempty to tell the environment that this is a module.
The shebang-stuff is present in the py-files in the bin-folder because they are python scripts that are supposed to be run from cli.

@oliver-zehentleitner oliver-zehentleitner merged commit ae9fed6 into LUCIT-Systems-and-Development:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants