Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ConstMetrics #31

Closed
brian-brazil opened this issue Oct 24, 2016 · 3 comments
Closed

Use ConstMetrics #31

brian-brazil opened this issue Oct 24, 2016 · 3 comments

Comments

@brian-brazil
Copy link
Contributor

This exporter is currently using direct instrumentation, which is strong discouraged for custom collectors. It should be switched to use ConstMetrics, and all the mutexes can then be removed.
@oliver006
Copy link
Owner

Not sure what you mean by this, do you have any relevant links to code or docs?

@brian-brazil
Copy link
Contributor Author

https://github.com/prometheus/memcached_exporter/blob/master/main.go has some examples.

@oliver006
Copy link
Owner

Cool, thanks!

@oliver006 oliver006 mentioned this issue Jul 24, 2018
Closed
@oliver006 oliver006 mentioned this issue May 10, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oliver006 @brian-brazil