Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide how to approach events in 1.14 #44

Closed
oliverdunk opened this issue Jul 5, 2019 · 0 comments
Closed

Decide how to approach events in 1.14 #44

oliverdunk opened this issue Jul 5, 2019 · 0 comments

Comments

@oliverdunk
Copy link
Owner

⚠️ If you're reading this because MCJukebox doesn't work on your 1.14 server, we're working on it! Technical details follow, you have been warned...

In 1.14, the Event class has a constructor that indicates if the event is called asynchronously or not.

For 1.14 compatibility, we need to either:

  • Keep our events as they are but start calling them synchronously, by running a task on the main thread.
  • Decide our events are intentionally asynchronous and specify it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliverdunk