Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated field [_routing] used, expected [routing] instead on 6.1.2 #686

Closed
swift1911 opened this issue Jan 18, 2018 · 10 comments
Closed
Assignees

Comments

@swift1911
Copy link

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.

Which version of Elastic are you using?

Deprecated field [_routing] used, expected [routing] instead on 6.1.2

[ ] elastic.v2 (for Elasticsearch 1.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[ ] elastic.v5 (for Elasticsearch 5.x)
[* ] elastic.v6 (for Elasticsearch 6.x)

Please describe the expected behavior

change _routing to use routing

Please describe the actual behavior

Deprecated field [_routing] used, expected [routing] instead in deprecation.log

Any steps to reproduce the behavior?

Must appear

@olivere
Copy link
Owner

olivere commented Jan 18, 2018

I've seen some places where this is required, but some places also where it hasn't changed from routing to _routing. Which API did you use?

@olivere olivere self-assigned this Jan 18, 2018
@swift1911
Copy link
Author

swift1911 commented Jan 18, 2018

@olivere
I use index Api Like:

elastic.NewBulkIndexRequest().Index(index_name).Type(log_model).Doc(item_json).Routing(app_name)

@olivere
Copy link
Owner

olivere commented Jan 18, 2018

Which version of elastic are you using?

The Bulk API has recently been changed. It is _routing now.

Please try to update to elastic.v6@v6.1.2 (or wait a few more hours to go to 6.1.3). That's the version of elastic.v6, not Elasticsearch.

@olivere olivere closed this as completed Jan 18, 2018
@olivere
Copy link
Owner

olivere commented Jan 18, 2018

Plus: With 6.1.2 you should get better performance with Bulk API.

@swift1911
Copy link
Author

image

@olivere
Copy link
Owner

olivere commented Jan 18, 2018

Sorry, I mixed up retry_on_conflict with routing/_routing.

They really shouldn't change these things in minor releases, at least without documenting it in the breaking changes.

I will fix it in elastic@v6.1.4.

@olivere olivere reopened this Jan 18, 2018
@olivere
Copy link
Owner

olivere commented Jan 18, 2018

Will be fixed in 6.1.4. It's still only deprecated, and will probably be removed in 7.x.

@olivere olivere closed this as completed Jan 18, 2018
@Smasherr
Copy link

Smasherr commented Oct 4, 2019

gitlab-elasticsearch-indexer uses olivere/elastic currently in version 5. We would like to get rid of deprecation warnings there as well and I already suggested a MR with update to v7. We want to stay compatible with elasticsearch 5.6 though, so update to oliviere/elastic/v7 is questionable.
@olivere Would that be somewhat possible to backport this change to v5 branch?

@olivere
Copy link
Owner

olivere commented Oct 6, 2019

@Smasherr Changing this in elastic.v5 due to a (breaking) change in ES 6.x would potentially break all users that use elastic.v5 with ES 5.x, as advised. While v5 might work with ES 6.x, and potentially a mix with other versions, I explicitly don't support this, so use at your own risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants