New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test error #75
Comments
It's not a known test failure and the only set up step you missed was being in a timezone far from UTC 😉
In JavaScript, calling So, what should the correct behaviour be? Is the test or implementation wrong? I think the test is wrong here, if I give lunr a date to index I don't think it should be changing the timezone of the date before indexing. Instead of trying to create a date from UTC the test should just create a date in the local timezone, I think. I'll fix the test so that this doesn't happen, thanks for taking the time to point it out, timezones are tricky! |
Is this believed fixed or still open? Just ran into it today, timezone is America/Edmonton, reproduce it like this:
All tests pass if I use a TZ east of prime meridian, eg |
I just forked the repository (everything is up to date), but I'm getting a test failure. Is this a known test failure or do I have something misconfigured? Was there supposed to be a build step before running the tests?
~/code/lunr.js (master) $ make test
Test failed: lunr.tokenizer: calling to string on passed val
Failed assertion: expected: tue,jan,01,2013, but was: mon,dec,31,2012
at http://localhost:32423/test/env/qunit.js:472
at http://localhost:32423/test/tokenizer_test.js:50
at http://localhost:32423/test/env/qunit.js:136
at http://localhost:32423/test/env/qunit.js:279
at process (http://localhost:32423/test/env/qunit.js:1277)
at http://localhost:32423/test/env/qunit.js:383
Took 58ms to run 297 tests. 296 passed, 1 failed.
make: *** [test] Error 1
The text was updated successfully, but these errors were encountered: