Skip to content
This repository has been archived by the owner on Oct 20, 2023. It is now read-only.

Banning mechisiam for unstable hashrate. #10

Closed
shtse8 opened this issue Sep 24, 2017 · 2 comments
Closed

Banning mechisiam for unstable hashrate. #10

shtse8 opened this issue Sep 24, 2017 · 2 comments

Comments

@shtse8
Copy link
Contributor

shtse8 commented Sep 24, 2017

When using pool farm like nicehash, the hashrate is very unstable during bidding.
the current mechisiam is checking the last 51 shares validition ratio. if it over 51%, the miningcore will ban the client. when low diff, and fast start from nicehash, shares submitted is too quick. once rejects occurs, it mush be banned as it can submit 51 invalid shares in one second.
so i would suggest to change the banning mechisiam to checking invalid ratio in period of time instead of hecking last n shares. it would be better for ubstable hashrate clients.

@oliverw
Copy link
Owner

oliverw commented Sep 24, 2017

Yes I agree. That would be a reasonable improvement.

@oliverw
Copy link
Owner

oliverw commented Oct 11, 2018

Feel free to submit a PR.

@oliverw oliverw closed this as completed Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants