[flow] The parameter passed to require() must be a literal string

[steida]

With 0.4.4 version.

if (state.opts.plugins) {
  const pluginsVisitors = state.opts.plugins.map((pluginName) => {
    const plugin = require(pluginName);
    return plugin({ template, types }).visitor;
  });

  programPath.traverse(visitors.merge(pluginsVisitors));
}

[oliviertassinari]

Is that an issue with flow parsing the source code of the project? I'm not sure how we could address it.

[steida]

Don't use dynamic require string I guess. I see, not sure how to solve it.

[oliviertassinari]

Regarding the why of this new lines of code, it can be summarized with that tweet.

I have been adding that line to the .flowconfig file. The best solution I could find.

[options]

module.ignore_non_literal_requires=true

[steida]

Thank you for the hint.

[oliviertassinari]

Also, you can tell flow to ignore the source of this package. I think that it's a better alternative to ignore_non_literal_requires.

[Andarist]

@oliviertassinari

Im not that sure what exact purpose this dynamic require serves here. From what I see its needed somehow because of certain combination of babel plugins and their unsafe ordering. Will it be possible to get rid of it once babel7 gets released which will address issue of plugins ordering by adding an option to specify which plugin should run first and which plugin should run later?

[oliviertassinari]

babel7 gets released which will address issue of plugins ordering by adding an option to specify which plugin should run first and which plugin should run later?

@Andarist Yes, hopefully, we should be able to remove the plugins option and the associated code.

[sandersky]

Worst case if you want to solve it in this repo you can add // $FlowFixMe above the line in question.

[oliviertassinari]

I'm closing the issue. I haven't seen a report for a long time. I'm assuming Flow stopped linting the node_modules.