Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Use default target if none specified #29

Closed
dlindenkreuz opened this issue Feb 19, 2017 · 1 comment
Closed

Use default target if none specified #29

dlindenkreuz opened this issue Feb 19, 2017 · 1 comment

Comments

@dlindenkreuz
Copy link

Currently, the component does not do anything if no target prop was specified.

It probably should use window or at least warn about a missing target.

@oliviertassinari
Copy link
Owner

oliviertassinari commented Feb 19, 2017

I think that we should make the target required. This package used to be a mixin, we hadn't the option at that time.

Providing a default value sounds like a bad idea, some events can only be listened on the document and window respectively. The choice needs to be explicit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants