Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for string format "date-time" leaf schema #149

Closed
RickMoynihan opened this issue Feb 24, 2022 · 3 comments
Closed

Add support for string format "date-time" leaf schema #149

RickMoynihan opened this issue Feb 24, 2022 · 3 comments

Comments

@RickMoynihan
Copy link
Contributor

The date-time string format is a common data type in openapi/swagger specs and has existing generator support in schema-generators and schema.core via the s/Inst schema. Consequently it should be as simple to add, as the number leaf schema was.

@RickMoynihan
Copy link
Contributor Author

RickMoynihan commented Feb 24, 2022

@oliyh
Copy link
Owner

oliyh commented Feb 24, 2022

Thanks, you made me realise that we didn't check if support for number generation was required in martian-test as part of that change.

@RickMoynihan
Copy link
Contributor Author

Yeah I actually checked if numbers generate and they do; though not sure if there's a test case for it explicitly in martian.test.

@oliyh oliyh closed this as completed in b72d030 Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants