-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate providing NBD from attaching NBD? #1
Comments
Sure, sounds like a good idea. Would something like #5 sufficient? |
That looks promising! I would reverse the names of the two main functions, though; the function called Otherwise, this looks good from inspection. |
#5 fixed this; closing. Thank you! |
Would you consider a new |
Thank you for building this, it looks great!
One request: would you consider separating the interface for responding to NBD requests given a
BlockDevice
implementation from the interface for attaching an NBD socket to the local system? That would make it easy to hook the former up to a server socket, and to use the latter to attach a remote socket to a local NBD device.The text was updated successfully, but these errors were encountered: