Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Chat Completion API contains non-existing "template" parameter #3514

Closed
ThomasVitale opened this issue Apr 6, 2024 · 0 comments · Fixed by #3515
Closed

Docs: Chat Completion API contains non-existing "template" parameter #3514

ThomasVitale opened this issue Apr 6, 2024 · 0 comments · Fixed by #3515
Labels
bug Something isn't working

Comments

@ThomasVitale
Copy link
Contributor

ThomasVitale commented Apr 6, 2024

What is the issue?

The ChatRequest type doesn't contain a template field (https://github.com/ollama/ollama/blob/main/api/types.go#L51), but the documentation lists it as an advanced parameter for the chat completion endpoint (https://github.com/ollama/ollama/blob/main/docs/api.md?plain=1#L397).

When included in a request, from what I can see, the Ollama server ignores it and always uses the template from the Modelfile (https://github.com/ollama/ollama/blob/main/server/routes.go#L1292).

What did you expect to see?

No response

Steps to reproduce

No response

Are there any recent changes that introduced the issue?

No response

OS

No response

Architecture

No response

Platform

No response

Ollama version

0.1.30

GPU

No response

GPU info

No response

CPU

No response

Other software

No response

@ThomasVitale ThomasVitale added bug Something isn't working needs-triage labels Apr 6, 2024
ThomasVitale added a commit to ThomasVitale/ollama that referenced this issue Apr 6, 2024
Fixes ollamagh-3514

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
jmorganca pushed a commit that referenced this issue Apr 6, 2024
Fixes gh-3514

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant