Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs need updated for langchainjs example #539

Closed
dprosper opened this issue Sep 16, 2023 · 3 comments
Closed

docs need updated for langchainjs example #539

dprosper opened this issue Sep 16, 2023 · 3 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@dprosper
Copy link

docs/tutorials/langchainjs.md

  1. Missing an await in
const loader = new CheerioWebBaseLoader("https://en.wikipedia.org/wiki/2023_Hawaii_wildfires");
const data = await loader.load();

without it you get to the .splitDocuments without any data.

  1. The cheerio module needs to be installed, i.e. npm install cheerio there is an error generated otherwise
Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'cheerio' imported from /../node_modules/langchain/dist/document_loaders/web/cheerio.js
    at new NodeError (node:internal/errors:405:5)
    at packageResolve (node:internal/modules/esm/resolve:887:9)
    at moduleResolve (node:internal/modules/esm/resolve:936:20)
    at defaultResolve (node:internal/modules/esm/resolve:1129:11)
    at nextResolve (node:internal/modules/esm/loader:163:28)
    at ESMLoader.resolve (node:internal/modules/esm/loader:835:30)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:18)
    at ESMLoader.import (node:internal/modules/esm/loader:524:22)
    at importModuleDynamically (node:internal/modules/esm/translators:110:35)
    at importModuleDynamicallyCallback (node:internal/process/esm_loader:35:14) {
  code: 'ERR_MODULE_NOT_FOUND'
}
@jmorganca jmorganca added documentation Improvements or additions to documentation examples labels Oct 11, 2023
@BruceMacD BruceMacD added the good first issue Good for newcomers label Nov 3, 2023
@aashish2057
Copy link
Contributor

docs updated in PR #992

@saikethan27
Copy link

@aashish2057 is Issue still open can I work on it

@aashish2057
Copy link
Contributor

@aashish2057 is Issue still open can I work on it

PR has been merged this issue should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants