Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx errors don't interrupt plugin execution #25

Closed
ollide opened this issue Apr 25, 2021 · 1 comment
Closed

dx errors don't interrupt plugin execution #25

ollide opened this issue Apr 25, 2021 · 1 comment
Assignees
Labels

Comments

@ollide
Copy link
Owner

ollide commented Apr 25, 2021

While discussing #24 it became apparent that the plugin currently won't interrupt its execution when dx encounters an error.

Quote from #24

I was able to reproduce your findings and you're right with the cached result that is being used by java2smali.

The plugin operates in 3 sequential steps:

  1. Trigger a module/project build for the given file (here, IDEA compiles the .java file into one or multiple .class file)
  2. Run dx.jar to transform the .class file(s) into a .dex file
  3. Run baksmali to transform the .dex file into the final .smali file

Step 1 fails, if IDEA is unable to compile the project / module. Step 3 fails whenever there's no dex file available from step 2 (this is the error from your first message). Unfortunately step 2 seems to fail silently, so baksmali may run on a previously emitted .dex file instead of throwing an error.

The goal here is to not fail silently and to stop the plugin execution properly.

@ollide ollide added the bug label Apr 25, 2021
@ollide ollide self-assigned this Apr 25, 2021
@ollide
Copy link
Owner Author

ollide commented Apr 25, 2021

Fixed in bcc4082

java2smali-dx-error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant