Stable 8ball #9
Merged
Stable 8ball #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a really good idea. The only drawback I would see with this is if one day someone asks something like: "Are you feeling good today Kitti?" and she gives an answer, and then the next day they ask the same thing and the exact same answer will be produced. Could get stale. Pros and cons with this one but I think the pros outweight the cons. |
|
Is it worth incorporating the current date in the hashed value? |
Yeah I think so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of the magic eight ball to always respond to the same question with the same answer, based on a hash of the question text.
Since this behaviour may or may not be actually desirable, feel free to reject this PR.