Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this repo (or an associated org) have the build pipelines for projects? #14

Open
s4ke opened this issue Feb 17, 2023 · 6 comments

Comments

@s4ke
Copy link
Contributor

s4ke commented Feb 17, 2023

Something that might come up when doing the feature requests on CSI drivers: Not all vendors will want to build the driver plugin images. Should we set up packaging build actions in this repo to produce all community maintained repackaging efforts? Or should we move this into a separate GitHub organization and leave this repo as the documentation hub?

@neersighted
Copy link

neersighted commented Feb 17, 2023

I'd suggest doing things here is helpful for now; if this picks up effort and the images need to be widely maintained, I'd like to entertain the idea of bringing it into the Moby project over spinning up a new org.

(or, as another wildcard idea, doing something under the aegis of Docker Official Images/the library images)

@s4ke
Copy link
Contributor Author

s4ke commented Feb 17, 2023

Okay, then I guess we should standardize on some kind of build tooling. I like the way the Makefile turned out https://github.com/hetznercloud/csi-driver/blob/main/deploy/docker-swarm/pkg/Makefile - based on https://github.com/costela/docker-volume-hetzner/blob/master/Makefile , should we standardize around this and then just set up the GitHub actions here?

Should we simply use ghcr.io or do we want to use docker.io? - I only have experience with ghcr.io with GitHub actions so I will need some help setting those up here in a PR.

@olljanat
Copy link
Owner

olljanat commented Feb 17, 2023

Personally I would like to see some Cloud providers/CSI driver projects to offer official support and encourage Swarm users to prefer those.

However to make make it easy for them it would make sense to have example GitHub action templates which they can use to ensure Swarm compatibility and release Docker plugin.

EDIT: Makefile for builds looks good. When it comes to publish, I'm not sure if other registries than docker.io works with these plugins? It have been while after I have tested anything else.

@Pat3ickI
Copy link

hey @olljanat thanks for this repo, but I have a question about <Docker Hub Organization> when building csi-driver-nfs I get error

Error response from daemon: plugin "csi-nfs:latest" not found
Error response from daemon: plugin "csi-nfs:latest" not found
Error response from daemon: plugin "patricki181/swarm-csi-nfs:v3" not found
Error response from daemon: plugin "patricki181/swarm-csi-nfs:v3" not found
Error response from daemon: No such container: rootfsimage
Unable to find image 'registry.k8s.io/sig-storage/nfsplugin:v3' locally
Error response from daemon: manifest for registry.k8s.io/sig-storage/nfsplugin:v3 not found: manifest unknown: Failed to fetch "v3"
Error response from daemon: No such container: rootfsimage
tar: This does not look like a tar archive
tar: Exiting with failure status due to previous errors
Error response from daemon: No such container: rootfsimage
patricki181/swarm-csi-nfs:v3
Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: reading spec: root mount propagation option must specify private or slave: "rshared": unknown
The push refers to repository [patricki181/swarm-csi-nfs]
3e22a0114af4: Preparing 
ed5b5310093b: Preparing 
f8d162d74247: Preparing 
error pushing plugin: server message: insufficient_scope: authorization failed
Error response from daemon: plugin is already disabled: plugin patricki181/swarm-csi-nfs:v3 found but disabled
patricki181/swarm-csi-nfs:v3
Error response from daemon: error resolving plugin reference: pull access denied, repository does not exist or may require authorization: server message: insufficient_scope: authorization failed

@olljanat
Copy link
Owner

@Patrickmitech when you register to https://hub.docker.com your will get organization which matches to your username.
If you don't need share that plugin between servers when you can just comment out those "push" commands and use just some random text instead of it.

You can also find already build version from https://hub.docker.com/r/ollijanatuinen/swarm-csi-nfs/tags

@Pat3ickI
Copy link

@olljanat Thank you for the explanation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants