Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: zoom bug in vertical reading if global zoom disabled #183

Closed
1 task done
dajotim937 opened this issue Dec 18, 2023 · 8 comments
Closed
1 task done

[Bug]: zoom bug in vertical reading if global zoom disabled #183

dajotim937 opened this issue Dec 18, 2023 · 8 comments
Assignees
Labels

Comments

@dajotim937
Copy link

dajotim937 commented Dec 18, 2023

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

OpenComic Version

1.0.0

Operating System

Win10, 22H2, build 19045

Steps to reproduce

  1. Disable global zoom
  2. Open webtoon
  3. Set vertical reading
  4. Scroll and stop between pages
  5. Click "original size"

Expected Behavior

Current page set in original size, next page moved out of view

Actual Behavior

Next page is still visible and overlap current page

Error message

No response

Additional Information

Screen record
2023-12-18_18-35-15.mp4

Sample file

No response

@dajotim937 dajotim937 added the bug label Dec 18, 2023
@dajotim937
Copy link
Author

dajotim937 commented Dec 18, 2023

Tell me if I should make separate issue.

One more bug with "original size" zoom. I have white lines at places where images are stitched

Screen record
2023-12-18_22-42-44.mp4

@ollm ollm self-assigned this Dec 20, 2023
@ollm
Copy link
Owner

ollm commented Dec 20, 2023

You can leave the issue report here, since it could be related, I will open another issue if the error is not related.

@ollm
Copy link
Owner

ollm commented Jan 13, 2024

Closed as completed in f83d17f and available in v1.1.0

@ollm ollm closed this as completed Jan 13, 2024
@dajotim937
Copy link
Author

image

Still has white lines at places where images are stitched for some files. Old ones from video above has disappeared.

@dajotim937
Copy link
Author

2024-01-17_23-22-59
2024-01-17_23-22-50

Here is same file and basically same picture. On screens there is page 14,15,16. Stitch between 14 and 15 without white line, but between 15 and 16 with white line.

@ollm
Copy link
Owner

ollm commented Jan 19, 2024

You can check this build, it has a small fix about it 26947a2, also make sure you are using the option "Do not enlarge more than its original size" e2f8598 #182 (comment), should cause less problems.

https://mega.nz/file/WDBmiLjZ#PDZOP6UB3sXXPoMwPLLKlxyX6SwEnOfKtCqaRzLSrww

If it still happens, can you check if is the images that have a white line, if not, could you send me the sample webtoon? oleguer.llopart.mora@gmail.com

It would also help to know what scale you are using on your monitor.

Captura de pantalla 2024-01-19 152147

@ollm ollm reopened this Jan 19, 2024
@dajotim937
Copy link
Author

make sure you are using the option "Do not enlarge more than its original size"

Already did.

It would also help to know what scale you are using on your monitor.

Never used scale. So it's 100% in settings.

@dajotim937
Copy link
Author

I downloaded same chapter from screenshots above and looks like yeah, the issue with images itself. Checked in SumatraPDF and also got line. And checked in Photoshop. Sorry. I'll write here again if I find line there it shouldn't be, but looks like it's fixed.

PS screenshots

2024-01-20_06-24-01
2024-01-20_06-23-49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants