Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work if the filename contains single quotes #55

Closed
lelinhtinh opened this issue Sep 18, 2020 · 9 comments
Closed

Doesn't work if the filename contains single quotes #55

lelinhtinh opened this issue Sep 18, 2020 · 9 comments
Assignees
Labels

Comments

@lelinhtinh
Copy link

If the filename contains single quotes ('), OpenComic stops at the image list and can't open the reading page.

@ollm ollm self-assigned this Sep 18, 2020
@ollm ollm added the bug label Sep 18, 2020
@ollm
Copy link
Owner

ollm commented Sep 18, 2020

I have tested it on both Windows and Ubuntu and it works fine. What operating system and App version do you use? It is possible that is fixed in the latest version of the App.

@lelinhtinh
Copy link
Author

OS: Pop!_OS 20.04 LTS x86_64
OpenComic: 0.2.0

@lelinhtinh
Copy link
Author

Notice single quotes (') before 'test.zip, it may have been removed during downloading.

@ollm
Copy link
Owner

ollm commented Sep 18, 2020

Notice single quotes (') before 'test.zip, it may have been removed during downloading.

I added the quote after downloading it.

Could you show what error appears in the console?

In: Debug > Toggle DevTools

Captura de pantalla de 2020-09-18 15-55-12
Here's a screenshot with the file open.

@lelinhtinh
Copy link
Author

image
image

@lelinhtinh
Copy link
Author

image

@ollm
Copy link
Owner

ollm commented Sep 18, 2020

It seems that the error is present only in the list view, I have changed from Grid to List and it has appeared.

While push the fix you can switch to the grid view to fix it.

@ollm
Copy link
Owner

ollm commented Sep 18, 2020

Fixed in 551dfb2

What package do you have installed? I do not plan to update the App soon, if you want I can compile a package with the error fixed.

@ollm ollm closed this as completed Sep 18, 2020
@lelinhtinh
Copy link
Author

lelinhtinh commented Sep 18, 2020

No need to rush, I was changed from List to Grid and temporarily satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants