Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] No Cost Approval Borrowing #20

Open
slendermaan opened this issue Dec 31, 2022 · 0 comments
Open

[Bug Report] No Cost Approval Borrowing #20

slendermaan opened this issue Dec 31, 2022 · 0 comments
Assignees

Comments

@slendermaan
Copy link

slendermaan commented Dec 31, 2022

Credit : HelloBloc

@clpi

Description

In the following code content, the error handling of x.bankKeeper.SendCoins is missing, which will result in a malicious lender being able to set the loan status to Approve without cost, and the borrower will not receive any funds.
image

Impact

a malicious lender being able to set the loan status to Approve without cost, and the borrower will not receive any funds.

Likelihood

This attack can be done by any user who does not have sufficient balance.

Related-Links

Related-Code

REF

Ethics

Sorry for using github to report this issue, as I didn't find your security channle and all the effective ways to report it at that time. However, I have observed that your main-net was not online at that time, so reported the issue via github. Hope you don't mind.

@clpi clpi self-assigned this Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants