Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary_sensor.washer_wash_completed is never goes to on #226

Closed
stefancvetkovic opened this issue Oct 10, 2021 · 32 comments
Closed

binary_sensor.washer_wash_completed is never goes to on #226

stefancvetkovic opened this issue Oct 10, 2021 · 32 comments
Labels

Comments

@stefancvetkovic
Copy link

Describe the bug
When washing machine is done with doing a laundry, I receive notification from lg app, but in that moment my sensor from integration never goes to on, machine goes to off mode and thats it.

Expected behavior
I would like after doing a laundry, machine stays online a little bit longer, in order to send that machine washing process is done.

@ollo69
Copy link
Owner

ollo69 commented Oct 10, 2021

This problem was already reported on other issues, but I'm not able to investigate without additional details.
The logic to turn on the sensor wash_completed is based on entity run_state and pre_state provided by the LG Api. What are the state for this 2 sensors when wash is completed?

@ollo69
Copy link
Owner

ollo69 commented Nov 8, 2021

Any news about this issue? Can we close?

@StanislavBolshakov
Copy link

StanislavBolshakov commented Dec 13, 2021

Any news about this issue? Can we close?

Hello. The issue is still in place. The last state reported by run_state is Spinning. pre_state is disabled by integration.

image

@ollo69
Copy link
Owner

ollo69 commented Dec 13, 2021

pre_state is disabled by integration.

You can enable to monitor it.

@StanislavBolshakov
Copy link

StanislavBolshakov commented Dec 14, 2021

According to the pre_state after the washing cycle is finished, the washing machine remains in the standby status
image

Second cycle last state was spinning
image

@ollo69
Copy link
Owner

ollo69 commented Jan 4, 2022

Seems that you are loosing some state transition, probably due to some connection problem with device or ThinQ cloud.
Try using last released version and than report here results and HA logs.

@DeadlySin2
Copy link

I have the same error today. All versions are leatest
F4E91DEA-B58E-4EF7-AD7F-DA9303AB8F23
CA5420CE-F654-4C87-8430-EB6FD574AB48

@ollo69
Copy link
Owner

ollo69 commented Jan 7, 2022

With only images I will never be able to investigate this issue. Could somebody provide log files?

@ghost
Copy link

ghost commented Jan 9, 2022

According to the pre_state after the washing cycle is finished, the washing machine remains in the standby status image

Second cycle last state was spinning image

I am seeing the same behavior, it seems to be 50/50 on whether pre_state goes from Spinning to 'Standby' or to '-' when a cycle finishes.

@TheFes
Copy link

TheFes commented Jan 10, 2022

Hi Ollo, you closed my issue as this was supposed to be a duplicate. (#185)
But i think my problem is different, I always have the same pre_state as run_state
image

Pre state:
image

Run state:
image

The states themselves seem to be correct.

@DeadlySin2
Copy link

Can you give me needed parameters for log file? I tried to make a log file but it is very big to post here…

@ollo69
Copy link
Owner

ollo69 commented Jan 10, 2022

But i think my problem is different, I always have the same pre_state as run_state

The title of the issue confused me, but in any case the issue is the same, what is different is the cause.
Provide me log (possible debug) with your washer machine running so that I can investigate returned payload.

@ollo69
Copy link
Owner

ollo69 commented Jan 10, 2022

Can you give me needed parameters for log file? I tried to make a log file but it is very big to post here…

If your log file is too big just delete (or rename) it and reboot HA, a new one will be generated.
To enable debug add this lines in configuration.yaml log section:

logger:
  default: info
  logs:
    custom_components.smartthinq_sensors: debug

@ollo69
Copy link
Owner

ollo69 commented Jan 11, 2022

@DeadlySin2,

looking at payload in your log:

  1. state and prestate are always equal
  2. state END is never trigger by your device

Due to this, the current logic used to determinate Run Completed cannot work at all. I don't know exactly which alternative logic I could implement, I'll think about this. In any case this is not an integration issue but a different behavior that have to be managed.

@github-actions
Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 23, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2022
@nchieffo
Copy link

nchieffo commented Sep 23, 2023

@ollo69 I think this should be reopened

A potential solution may be to use the sensor sensor.xxx_remaining_time
when the sensor changes from 01:00 minute to 00:00, if xxx_run_state is set to '-', the program is ended.

image

@ollo69
Copy link
Owner

ollo69 commented Sep 27, 2023

Ok, I re-open this, but is unclear why Run-state and Pre-state are always the same.
Just trigger the sensor based on your suggestion is not really correct: a power failure could generate the same condition but should not be considered wash completed.
Attach your device diagnostic immediately before and immediately after that the wash cycle end, I will check if there is a way to determinate wash-complete for this conditions.

@ollo69 ollo69 reopened this Sep 27, 2023
@nchieffo
Copy link

nchieffo commented Sep 27, 2023

Hey @ollo69
here's the logfile I was able to collect, please tell me if I obfuscated too much data.
Unfortunately it seems the debugger captured only 3 messages and all of them seems to refer to the machine still running, even though I hit the disable recording button only once the washing machine state changed to off. Not sure what happened.
I prepared a second log file with a response of the machine at rest, but I'm not sure if it's useful or not. please tell me if I need to provide a second recording (this time I will wait a couple of minutes after the machine turns off)

home-assistant_smartthinq_sensors_2023-09-27T19-09-36.595Z.obfuscated.log.txt

2023-09-27 212851.507 DEBUG (MainTh.txt

Thanks for your time

@github-actions github-actions bot removed the Stale label Sep 28, 2023
@nchieffo
Copy link

nchieffo commented Sep 28, 2023

OK I got a new file with 1 message before the cycle ends, and 1 message after.
last before and first after cycle ends.txt

I also took a quick look at the diff, which is not so much promising

Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 13, 2023
@nchieffo
Copy link

Still an issue

@github-actions github-actions bot removed the Stale label Nov 14, 2023
Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 30, 2023
Copy link

github-actions bot commented Jan 6, 2024

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2024
@nchieffo
Copy link

nchieffo commented Jan 6, 2024

Worth reopening

@Trilis29
Copy link

Trilis29 commented Feb 3, 2024

any update?

@ollo69 ollo69 reopened this Feb 20, 2024
@ollo69
Copy link
Owner

ollo69 commented Feb 20, 2024

I reopen this issue because I made some changes to support run_completed for these devices that do not provide end state. Can you please test is last release fix the problem?

@Trilis29
Copy link

for me last update fixed

@ollo69
Copy link
Owner

ollo69 commented Feb 20, 2024

@Trilis29 ,

thanks for you feed-back, but please test last release (v0.38.3) because I review a little bit the code from previous one and I just want to be sure that still work properly.

Thanks 👍

@Trilis29
Copy link

image
Seems working.

Copy link

github-actions bot commented Apr 7, 2024

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Apr 7, 2024
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants