Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs report for your code #5

Closed
shixianwen opened this issue Oct 4, 2017 · 1 comment
Closed

Bugs report for your code #5

shixianwen opened this issue Oct 4, 2017 · 1 comment

Comments

@shixianwen
Copy link

Hi, my name is Shixian Wen. I am currently a computer science Ph.D. student at University of Southern California.
Your code is great, but I found some small bugs that could be some problems.
1:
in line #250 you cannot define MultiRNNCell([lstm_cell] * FLAGS.num_layers_g, state_is_tuple=True) like this. you should use something like [cell for _ in range(config.num_layers)] in https://github.com/tensorflow/models/blob/master/tutorials/rnn/ptb/ptb_word_lm.py official tutorial.
The reason is here
https://stackoverflow.com/questions/45456116/valueerror-trying-to-share-variable-enco-gru-cell-gates-kernel-but-specified-s

2:
you did not update the state c and state h for discriminator and generator:
You were trying to update the state in generator from #557 to #559 for generator, but you comment it out.
You did not update the state of discriminator at all.
see the code in ptb_word_lm.py #402 to #402
The reason is here:
https://stackoverflow.com/questions/40991975/how-are-the-batches-iterated-in-the-ptb-lstm-example-of-tensorflow/40998815#40998815

@olofmogren
Copy link
Owner

Dear Shixian,
Thank you for your comments. Your first comment refers to something that changed in tensorflow after the experiments were done. You will have to make the change according to your comment if you'd like to run this with a more recent vesion of tensorflow. (I don't remember in which version this was changed, but I believe that the published experiments were run with TF 0.11). Your second comment may be right. It was probabily a mistake on my part. Feel free to try with the initialization and see how it performs. I doubt that this will affect the results in any way that is comparable to a language model.
Best regards, Olof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants