Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more spiders #67

Merged
merged 5 commits into from
Feb 11, 2021
Merged

Add more spiders #67

merged 5 commits into from
Feb 11, 2021

Conversation

qnVictoria
Copy link
Collaborator

New spiders:

  • homebase spider
  • allo_ua spider

oltarasenko
oltarasenko reviewed Feb 9, 2021
View reviewed changes
examples/lib/shops/spiders/allo_ua.ex Outdated
{:ok, document} = Floki.parse_document(response.body)

# Extract individual product page URLs
urls =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also extract links from pagination here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

oltarasenko
oltarasenko reviewed Feb 9, 2021
View reviewed changes
Copy link
Collaborator

@oltarasenko oltarasenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two minor fixes are requested

@oltarasenko oltarasenko merged commit 99cb749 into master Feb 11, 2021
@oltarasenko oltarasenko deleted the add-more-spiders branch February 11, 2021 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oltarasenko oltarasenko oltarasenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qnVictoria @oltarasenko