What self.psuedo_line is for?

[fxmarty]

Hello,

Thank you for this great addon, it is awesome. I am working on something based on it and had a small question.

I was wondering what the attribute self.psuedo_line was for in the class drawing_layer:

in

interSubs/interSubs.py

Line 1308 in 4387336

self.psuedo_line = 0

It happens that I had an issue similar to #12 where the first subtitle after pressing F5 would be visible, but not the following ones. Even though the following subtitles would be invisible, I could hover over them and see translations.

removing this bit of code

interSubs/interSubs.py

Lines 1353 to 1355 in 4387336

	if not self.psuedo_line:
	self.psuedo_line = 1
	return

and hence always triggering draw_text_n_outline allowed me to solve the problem and now I can see all subtitles, not only the first one.

Hence my question: what is this self.psuedo_line and why do we want to trigger draw_text_n_outline only once at the beginning?

Edit: I wonder if this has to do with the compositor. If this is useful, I use KDE, with those configs

and I have xcompmgr package install, but I don't know at all if it is used or not.

Thanks again for the great script!

[oltodosel]

It prevents calling of paintEvent() for the second time. I don't remember why exactly it is called again, something to do with how Qt works or smth...
Try adding os.system('notify-send %s' % time.time()) after those 3 lines you removed and see for yourself.

Edit:
As far as I remember this was to prevent barely noticeable flickering of subtitles when paintEvent() was triggered the second time.

[fxmarty]

Thanks a lot! I managed to do something simpler, still have to test it with mpv, closing.

Edit: BTW, up to now I did not find how to disable the fading there is by default with interSubs.

[oltodosel]

What fading?

[fxmarty]

Oh, so maybe it is only on my side... Basically, when a subtitle disappears and also when a subtitle appears, it fades in/fades out. This is not an "instantaneous" apparition/disappearance.

[oltodosel]

Definitely smth to do with your compositor or WM.

[fxmarty]

I see thanks a lot, I will investigate that :-)

[fxmarty]

Just in case somebody has the fading issue one day: in KDE, you have a fading option in "Desktop Effects" options that you must disable. Alternatively, it would be nice to not destroy the widget at every subs, but that does the trick!