fix: revert 1.6.0 3rd attempt #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7046f63.
When the tagged commit is added to the repo, we need the docker tags workflow to create the container images. If we set the ci to skip, then the workflow is not triggered.
The GITHUB_TOKEN does not allow triggering of workflows. The persisted credentials from the actions/checkout overrides the env tokens used by semantic release and therefore these credentials must be purged. This allows the PAT to create the new version commit and tag to allow the docker workflow to create the docker images witht he correct release tag versions.
Allow the workflow to be cancelled by evaluating failure
|
Hey there and thank you for opening this pull request! 👋🏼 You can pull a preview container image of dali with the below command: docker pull ghcr.io/olxgroup-oss/dali/dali:revert-1.6.0-3rd-attempt |
|
This PR is included in version 1.6.0 🎉 |
1 similar comment
|
This PR is included in version 1.6.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A separate testing repo was used to determine the issues with the current workflow.
actions/checkoutoverride the semantic-release ENV vars of GH_TOKEN or GITHUB_TOKEN, when set to a PAT, and also do not trigger workflows.[skip ci]commit message also blocks the workflow running on tagsThe organisation has been setup for PATs and a SEM_REL_TOKEN was created in this repo as an action repository secret. The value of the token is from my personal access token;
OLX_SEM_REL_PAT, expiring 30.09.2024, scoped to this repo only, with the following scopes for semantic-release to succeed.fixes #11