Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adds new CLI parameter entrypoint #12

Merged
merged 16 commits into from Dec 11, 2022

Conversation

paolorechia
Copy link
Contributor

@paolorechia paolorechia commented Dec 6, 2022

Implements suggestion from this issue: #11

The commits are rather dirty, please let me know if I should squash them.

I only tested locally with Python 3.10 with the following parameters (using pip install -e .)

ptw .
ptw . --now
ptw . --now --entrypoint tox
ptw . --entrypoint tox

pytest_watcher/watcher.py Outdated Show resolved Hide resolved
pytest_watcher/watcher.py Outdated Show resolved Hide resolved
pytest_watcher/watcher.py Outdated Show resolved Hide resolved
pytest_watcher/watcher.py Outdated Show resolved Hide resolved
@paolorechia
Copy link
Contributor Author

Thanks for the quick review!

I will do the changes when I get some free time over the next days.

If you prefer to revert the dataclass decorator I can do that as well, I was not aware it wasn’t available in Python 3.6.

@paolorechia
Copy link
Contributor Author

@olzhasar I've made the requested changes and dropped support for py36 in tox.ini, please double check

I've tested with these

 ptw . 
 ptw . --now
 ptw . --runner tox
 ptw . --now --runner tox -v

@olzhasar
Copy link
Owner

@paolorechia
I've made some minor changes for clarity
Overall, looks good to me!
Feel free to merge it

Thanks for the contribution!

@paolorechia
Copy link
Contributor Author

@olzhasar Thanks again for reviewing! Happy to contribute.

I don't think I have permission to merge this PR, would you mind doing it?

I also forgot to ask before, but I guess we should bump the version and release a new package.

@olzhasar
Copy link
Owner

@paolorechia
That's strange, I'll check permissions.
Yes, I'll release a new version soon, probably tommorow

@olzhasar olzhasar merged commit 496ad83 into olzhasar:master Dec 11, 2022
@olzhasar olzhasar added the enhancement New feature or request label Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants