Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Python 3.10 #3

Merged
merged 1 commit into from Dec 30, 2021
Merged

Test on Python 3.10 #3

merged 1 commit into from Dec 30, 2021

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Dec 8, 2021

Python 3.10 was released on 2021-10-04:

$ tox -e py310
.package create: /private/tmp/pytest-watcher/.tox/.package
.package installdeps: poetry-core>=1.0.0
py310 create: /private/tmp/pytest-watcher/.tox/py310
py310 installdeps: watchdog, pytest, pytest-mock, freezegun
py310 inst: /private/tmp/pytest-watcher/.tox/.tmp/package/1/pytest-watcher-0.2.1.tar.gz
py310 installed: attrs==21.2.0,freezegun==1.1.0,iniconfig==1.1.1,packaging==21.3,pluggy==1.0.0,py==1.11.0,pyparsing==3.0.6,pytest==6.2.5,pytest-mock==3.6.1,pytest-watcher @ file:///private/tmp/pytest-watcher/.tox/.tmp/package/1/pytest-watcher-0.2.1.tar.gz,python-dateutil==2.8.2,six==1.16.0,toml==0.10.2,watchdog==2.1.6
py310 run-test-pre: PYTHONHASHSEED='546577221'
py310 run-test: commands[0] | pytest
========================================================== test session starts ===========================================================
platform darwin -- Python 3.10.1, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
cachedir: .tox/py310/.pytest_cache
rootdir: /private/tmp/pytest-watcher
plugins: mock-3.6.1
collected 21 items

tests/test_pytest_watcher.py .....................                                                                                 [100%]

=========================================================== 21 passed in 0.75s ===========================================================
________________________________________________________________ summary _________________________________________________________________
  py310: commands succeeded
  congratulations :)

@hugovk
Copy link
Contributor Author

hugovk commented Dec 8, 2021

I'd add the 3.10 Trove classifier, but where are they defined?

image

https://pypi.org/project/pytest-watcher/

3.6 should be in the list according to README.md and tox.ini.

@olzhasar olzhasar merged commit 54d0658 into olzhasar:master Dec 30, 2021
@olzhasar
Copy link
Owner

olzhasar commented Dec 30, 2021

@hugovk Thank you for taking your time to contribute. I was quite busy lately on my daily job and didn't have much time for open source projects.

Speaking of Python versions classifiers, according to Poetry documentation here, they should be added automatically based on Python versions specified in pyproject.toml. I just released a new version, but for some reason it didn't add 3.10 record yet. Probably I will need to investigate it a little bit more.

UPDATE:
Turned out missing Python3.10 identifier was a Poetry issue. I updated the poetry version on my system and managed to build with proper classifiers

@hugovk hugovk deleted the add-3.10 branch December 30, 2021 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants